On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > PMF TA (Trusted Application) loads via the TEE environment into the > AMD ASP. > > PMF-TA supports two commands: > 1) Init: Initialize the TA with the PMF Smart PC policy binary and > start the policy engine. A policy is a combination of inputs and > outputs, where; > - the inputs are the changing dynamics of the system like the user > behaviour, system heuristics etc. > - the outputs, which are the actions to be set on the system which > lead to better power management and enhanced user experience. > > PMF driver acts as a central manager in this case to supply the > inputs required to the TA (either by getting the information from > the other kernel subsystems or from userland) > > 2) Enact: Enact the output actions from the TA. The action could be > applying a new thermal limit to boost/throttle the power limits or > change system behavior. > > Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> > --- > drivers/platform/x86/amd/pmf/pmf.h | 10 +++ > drivers/platform/x86/amd/pmf/tee-if.c | 97 ++++++++++++++++++++++++++- > 2 files changed, 106 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h > index 02460c2a31ea..e0837799f521 100644 > --- a/drivers/platform/x86/amd/pmf/pmf.h > +++ b/drivers/platform/x86/amd/pmf/pmf.h > @@ -59,6 +59,9 @@ > #define ARG_NONE 0 > #define AVG_SAMPLE_SIZE 3 > > +/* TA macros */ > +#define PMF_TA_IF_VERSION_MAJOR 1 > + > /* AMD PMF BIOS interfaces */ > struct apmf_verify_interface { > u16 size; > @@ -184,6 +187,7 @@ struct amd_pmf_dev { > struct tee_shm *fw_shm_pool; > u32 session_id; > void *shbuf; > + struct delayed_work pb_work; > bool smart_pc_enabled; > }; > > @@ -395,6 +399,12 @@ struct apmf_dyn_slider_output { > struct apmf_cnqf_power_set ps[APMF_CNQF_MAX]; > } __packed; > > +/* cmd ids for TA communication */ > +enum ta_pmf_command { > + TA_PMF_COMMAND_POLICY_BUILDER_INITIALIZE, > + TA_PMF_COMMAND_POLICY_BUILDER_ENACT_POLICIES, > +}; > + > struct ta_pmf_shared_memory { > int command_id; > int resp_id; > diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c > index 4db80ca59a11..1b3985cd7c08 100644 > --- a/drivers/platform/x86/amd/pmf/tee-if.c > +++ b/drivers/platform/x86/amd/pmf/tee-if.c > @@ -13,9 +13,96 @@ > #include "pmf.h" > > #define MAX_TEE_PARAM 4 > + > +/* Policy binary actions sampling frequency (in ms) */ > +static int pb_actions_ms = 1000; MSEC_PER_SEC (from #include <linux/time.h>, don't include the vdso one). > +#ifdef CONFIG_AMD_PMF_DEBUG > +module_param(pb_actions_ms, int, 0644); > +MODULE_PARM_DESC(pb_actions_ms, "Policy binary actions sampling frequency (default = 1000ms)"); > +#endif -- i.