On 10/2/23 12:48, Michel Dänzer wrote: > On 10/2/23 12:05, Michel Dänzer wrote: >> On 9/29/23 22:41, Hamza Mahfooz wrote: >>> From: Ivan Lipski <ivlipski@xxxxxxx> >>> >>> This reverts commit 45e1ade04b4d60fe5df859076005779f27c4c9be. >>> >>> Since, it causes the following IGT tests to fail: >>> kms_cursor_legacy@cursor-vs-flip.* >>> kms_cursor_legacy@flip-vs-cursor.* >> >> Any information about how those tests fail? Maybe they accidentally rely on the broken behaviour? > > I was able to reproduce, that doesn't seem to be the case. They just rely on multiple legacy cursor ioctl calls being able to complete between consecutive flips, which I suppose is broken by always pulling in non-cursor plane state with any cursor plane state changes. > > I'll see if I can find a better solution. Meanwhile, > > Acked-by: Michel Dänzer <mdaenzer@xxxxxxxxxx> > > for the revert. Alternatively, here's an incremental fix: https://patchwork.freedesktop.org/series/124527/ -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer
