Hi, The $Subject could be improved, e.g.: [PATCH] drm/amd/display: add kernel docs for dc_dmub_caps On 9/29/23 03:00, Sagar Vashnav wrote: > Add kernel documentation for the dc_dmub_caps structure. > > Signed-off-by: Sagar Vashnav <sagarvashnav72427@xxxxxxxxx> Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Thanks. > --- > drivers/gpu/drm/amd/display/dc/dc.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h > index 8125839..14b4c50 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc.h > +++ b/drivers/gpu/drm/amd/display/dc/dc.h > @@ -208,6 +208,16 @@ struct dc_color_caps { > struct mpc_color_caps mpc; > }; > > +/** > + * struct dc_dmub_caps - DMUB (Display Microcontroller Unit) capabilities > + * @psr: support for PSR (Power Saving State Residency) > + * @mclk_sw: support for MCLK_SW (Memory Clock Switch) > + * @subvp_psr: support for SUBVP PSR (Sub-Viewport Power Saving State Residency) > + * @gecc_enable: GECC (Global Error Correcting Code) enablement. > + * > + * This structure describes the capabilities of the Display Microcontroller Unit (DMUB). > + * It specifies whether certain features like PSR and MCLK_SW are supported. > + */ > struct dc_dmub_caps { > bool psr; > bool mclk_sw; -- ~Randy