Hi Luca, Am Freitag, dem 29.09.2023 um 18:48 +0200 schrieb Luca Ceresoli: > Hi Lucas, > > On Thu, 28 Sep 2023 14:55:35 +0200 > Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > > > Add binding for the i.MX8MP HDMI parallel video interface block. > > > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > .../display/imx/fsl,imx8mp-hdmi-pvi.yaml | 83 +++++++++++++++++++ > > 1 file changed, 83 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > > new file mode 100644 > > index 000000000000..df29006b4090 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pvi.yaml > > @@ -0,0 +1,83 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/imx/fsl,imx8mp-hdmi-pvi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Freescale i.MX8MP HDMI Parallel Video Interface > > + > > +maintainers: > > + - Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > + > > +description: | > > + The HDMI parallel video interface is a timing and sync generator block in the > > + i.MX8MP SoC, that sits between the video source and the HDMI TX controller. > > + > > +properties: > > + compatible: > > + const: fsl,imx8mp-hdmi-pvi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Input from the LCDIF controller. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Output to the HDMI TX controller. > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > Sure it is required? In the imx8mp.dtsi I have, which comes for a patch > you sent previously, there is no 'interrupts' property, and HDMI works. > Yes, the driver doesn't use/enforce this interrupt at the moment and will work without it. But since the IRQ is present in the only known HW implementation of this IP, I don't see a reason to make it optional in the DT, as that's just proper description of the HW. > > + - power-domains > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/power/imx8mp-power.h> > > + > > + display-bridge@32fc4000 { > > + compatible = "fsl,imx8mp-hdmi-pvi"; > > + reg = <0x32fc4000 0x40>; > > The device has up to register 0x40, thus I guess the second value should > be 0x44 here. Or maybe 0x100, just to be comfortable. :) > Right, I'll fix that. Regards, Lucas
