On Thu, Sep 28, 2023 at 12:51:15PM -0500, Steve Wahl wrote: > On Thu, Sep 28, 2023 at 03:21:36PM +0200, Joel Granados via B4 Relay wrote: > > From: Joel Granados <j.granados@xxxxxxxxxxx> > > > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arrays (sentinels) which > > will reduce the overall build time size of the kernel and run time > > memory bloat by ~64 bytes per sentinel (further information Link : > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/) > > > > Remove sentinel from xpc_sys_xpc_hb and xpc_sys_xpc > > > > Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx> > > --- > > drivers/misc/sgi-xp/xpc_main.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c > > index 6da509d692bb..c898092ff3ac 100644 > > --- a/drivers/misc/sgi-xp/xpc_main.c > > +++ b/drivers/misc/sgi-xp/xpc_main.c > > @@ -109,8 +109,7 @@ static struct ctl_table xpc_sys_xpc_hb[] = { > > .mode = 0644, > > .proc_handler = proc_dointvec_minmax, > > .extra1 = &xpc_hb_check_min_interval, > > - .extra2 = &xpc_hb_check_max_interval}, > > - {} > > + .extra2 = &xpc_hb_check_max_interval} > > }; > > static struct ctl_table xpc_sys_xpc[] = { > > { > > @@ -120,8 +119,7 @@ static struct ctl_table xpc_sys_xpc[] = { > > .mode = 0644, > > .proc_handler = proc_dointvec_minmax, > > .extra1 = &xpc_disengage_min_timelimit, > > - .extra2 = &xpc_disengage_max_timelimit}, > > - {} > > + .extra2 = &xpc_disengage_max_timelimit} > > }; > > > > static struct ctl_table_header *xpc_sysctl; > > > > -- > > 2.30.2 > > > > I assume you'll match the rest of the changes with regards to the > trailing comma. If you are refering to Greg's comments. yes. I'll send a V2 with the trailing comma. Best > > Reviewed-by: Steve Wahl <steve.wahl@xxxxxxx> > > -- > Steve Wahl, Hewlett Packard Enterprise -- Joel Granados
Attachment:
signature.asc
Description: PGP signature
