On Fri, Sep 22, 2023 at 03:45:45PM +0300, Imre Deak wrote: Hi Mitul, Ankit, Swati, Vandita, > On Wed, Sep 13, 2023 at 11:35:58AM +0530, Mitul Golani wrote: > > his patch series adds support for DSC fractional compressed bpp > > for MTL+. The series starts with some fixes, followed by patches that > > lay groundwork to iterate over valid compressed bpps to select the > > 'best' compressed bpp with optimal link configuration (taken from > > upstream series: https://patchwork.freedesktop.org/series/105200/). > > > > The later patches, add changes to accommodate compressed bpp with > > fractional part, including changes to QP calculations. > > To get the 'best' compressed bpp, we iterate over the valid compressed > > bpp values, but with fractional step size 1/16, 1/8, 1/4 or 1/2 as per > > sink support. > > > > The last 2 patches add support to depict DSC sink's fractional support, > > and debugfs to enforce use of fractional bpp, while choosing an > > appropriate compressed bpp. > > MST/DSC is at the moment broken, so I'd prefer merging this patchset > only after it's fixed. This would mean merging > > https://lore.kernel.org/all/20230921195159.2646027-1-imre.deak@xxxxxxxxx > > first, followed by the DSC parts from > > https://lore.kernel.org/all/20230914192659.757475-1-imre.deak@xxxxxxxxx > > which would also need a rebase for this patchset. Are you ok with the above? Thanks, Imre > > > Ankit Nautiyal (5): > > drm/display/dp: Add helper function to get DSC bpp prescision > > drm/i915/display: Store compressed bpp in U6.4 format > > drm/i915/display: Consider fractional vdsc bpp while computing m_n > > values > > drm/i915/audio : Consider fractional vdsc bpp while computing tu_data > > drm/i915/dp: Iterate over output bpp with fractional step size > > > > Swati Sharma (2): > > drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp > > drm/i915/dsc: Allow DSC only with fractional bpp when forced from > > debugfs > > > > Vandita Kulkarni (1): > > drm/i915/dsc/mtl: Add support for fractional bpp > > > > drivers/gpu/drm/display/drm_dp_helper.c | 27 ++++++ > > drivers/gpu/drm/i915/display/icl_dsi.c | 11 +-- > > drivers/gpu/drm/i915/display/intel_audio.c | 17 ++-- > > drivers/gpu/drm/i915/display/intel_bios.c | 6 +- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 6 +- > > drivers/gpu/drm/i915/display/intel_display.c | 8 +- > > drivers/gpu/drm/i915/display/intel_display.h | 2 +- > > .../drm/i915/display/intel_display_debugfs.c | 83 +++++++++++++++++++ > > .../drm/i915/display/intel_display_types.h | 4 +- > > drivers/gpu/drm/i915/display/intel_dp.c | 81 +++++++++++------- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 32 ++++--- > > drivers/gpu/drm/i915/display/intel_fdi.c | 2 +- > > .../i915/display/intel_fractional_helper.h | 36 ++++++++ > > .../gpu/drm/i915/display/intel_qp_tables.c | 3 - > > drivers/gpu/drm/i915/display/intel_vdsc.c | 30 +++++-- > > include/drm/display/drm_dp_helper.h | 1 + > > 16 files changed, 275 insertions(+), 74 deletions(-) > > create mode 100644 drivers/gpu/drm/i915/display/intel_fractional_helper.h > > > > -- > > 2.25.1 > >