On 9/27/2023 9:04 AM, Andi Shyti wrote:
Hi Nirmoy,
On Tue, Sep 26, 2023 at 11:58:02PM +0200, Nirmoy Das wrote:
On MTL GEN12_RING_FAULT_REG is not replicated so don't
do mcr based operation for this register.
v2: use MEDIA_VER() instead of GRAPHICS_VER()(Matt).
Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
This looks very good!
My tired brain took it as end of mail.
- if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) {
+ /*
+ * for media tile this ring fault register is not replicated
+ * so skip doing mcr ops on it.
Can we spare a few more words on "doing mcr ops on it"?
Sent out
https://patchwork.freedesktop.org/patch/559759/?series=124325&rev=1
to improve this.
Thanks,
Nirmoy
Andi
