On Fri, 2023-09-22 at 16:51 +0100, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 04:49:14PM +0100, Conor Dooley wrote: > > On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > > > Add a compatible string for the COLOR block in MediaTek MT8195 > > > that > > > is controlled by MDP3. > > > > > > Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx> > > > --- > > > .../devicetree/bindings/display/mediatek/mediatek,color.yaml > > > | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,col > > > or.yaml > > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,col > > > or.yaml > > > index f21e44092043..b886ca0d89ea 100644 > > > --- > > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,col > > > or.yaml > > > +++ > > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,col > > > or.yaml > > > @@ -26,6 +26,7 @@ properties: > > > - mediatek,mt2701-disp-color > > > - mediatek,mt8167-disp-color > > > - mediatek,mt8173-disp-color > > > + - mediatek,mt8195-mdp3-color > > > > How come this one is a "mdp3" not a "disp"? > > I don't know what mdp3 means & googling gives me no answers. What's > the > "disp" one controlled by, since it isn't controlled by mdp3? > Hi Conor, Mediatek's Media Data Path ver.3 (MDP3) is associated with MMSYS and acts as an independent driver that operates between VDEC and DISP. By controlling multiple components, it carries out tasks like converting color formats, resizing, and applying specific Picture Quality (PQ) effects. The driver can be found at "driver/media/platform/mediatek/mdp3". Since the same hardware components are configured in both MDP3 and DISP, considering previous discussions, I attemped to integrate into a single binding, named after the controlling user. Sincerely, Moudy > > > > > - items: > > > - enum: > > > - mediatek,mt7623-disp-color > > > -- > > > 2.18.0 > > > > >