Hi, On Mon, Sep 18, 2023 at 9:19 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Mon, Jul 3, 2023 at 6:21 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > > This is two patches fixing things I would normally complain about > > in reviews, but alas I missed this one, so I go in and fix it up > > myself. > > > > Discovering that a completely unrelated driver has been merged > > into this panel driver I had to bite the bullet and break it out. > > I am pretty suspicious of the other recently added panel as well. > > > > I am surprised that contributors from manufacturers do not seem > > to have datasheets for the display controllers embedded in the > > panels of their products. Can you take a second look? > > > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > --- > > Changes in v3: > > - Rebase on drm-misc-next > > - Convert the two newly added Starry panels as well. > > - Break out the obvious ILI9882t-based panel into its own driver. > > - Link to v2: https://lore.kernel.org/r/20230615-fix-boe-tv101wum-nl6-v2-0-457d7ece4590@xxxxxxxxxx > > > > Changes in v2: > > - Fix a missed static keyword > > - Link to v1: https://lore.kernel.org/r/20230615-fix-boe-tv101wum-nl6-v1-0-8ac378405fb7@xxxxxxxxxx > > > > --- > > Linus Walleij (4): > > drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences > > drm/panel: boe-tv101wum-nl6: Drop surplus prepare tracking > > drm/panel: ili9882t: Break out as separate driver > > drm/panel: ili9882t: Break out function for switching page > > > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 3037 ++++++++++-------------- > > drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 759 ++++++ > > 4 files changed, 2067 insertions(+), 1739 deletions(-) > > I'm curious what the latest on this patch series is. Is it abandoned, > or is it still on your list to move forward with it? If it's > abandoned, does that mean we've abandoned the idea of breaking > ili9882t into a separate driver? > > From looking at things that have landed downstream in the ChromeOS > kernel trees it looks as if additional fixes are getting blocked from > being posted/landed because of the limbo state that this is in. I presume Linus is busy or otherwise indisposed. So I guess we have two options here: a) Cong Yang can post any relevant fixes to the existing "monolithic" panel driver so that we can get them landed and at least get things fixed. - or - b) Cong Yang could take over all or some of Linus's series and post new versions of it, addressing feedback. I would tend to say we should go with "a)" because I think Linus needs to be involved in some of the cleanup discussions. -Doug
