Re: [PATCH 0/8] Add DSC fractional bpp support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,


For coding style and wording part, this version looks fine for me after a brief skim.
Thanks for the patch. :-)


On 2023/9/26 16:23, Mitul Golani wrote:
This patch series adds support for DSC fractional compressed bpp
for MTL+. The series starts with some fixes, followed by patches that
lay groundwork to iterate over valid compressed bpps to select the
'best' compressed bpp with optimal link configuration (taken from
upstream series: https://patchwork.freedesktop.org/series/105200/).

The later patches, add changes to accommodate compressed bpp with
fractional part, including changes to QP calculations.
To get the 'best' compressed bpp, we iterate over the valid compressed
bpp values, but with fractional step size 1/16, 1/8, 1/4 or 1/2 as per
sink support.

The last 2 patches add support to depict DSC sink's fractional support,
and debugfs to enforce use of fractional bpp, while choosing an
appropriate compressed bpp.

Ankit Nautiyal (5):
   drm/display/dp: Add helper function to get DSC bpp precision
   drm/i915/display: Store compressed bpp in U6.4 format
   drm/i915/display: Consider fractional vdsc bpp while computing m_n
     values
   drm/i915/audio : Consider fractional vdsc bpp while computing tu_data
   drm/i915/dp: Iterate over output bpp with fractional step size

Swati Sharma (2):
   drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp
   drm/i915/dsc: Allow DSC only with fractional bpp when forced from
     debugfs

Vandita Kulkarni (1):
   drm/i915/dsc/mtl: Add support for fractional bpp

  drivers/gpu/drm/display/drm_dp_helper.c       | 27 ++++++
  drivers/gpu/drm/i915/display/icl_dsi.c        | 11 +--
  drivers/gpu/drm/i915/display/intel_audio.c    | 17 ++--
  drivers/gpu/drm/i915/display/intel_bios.c     |  6 +-
  drivers/gpu/drm/i915/display/intel_cdclk.c    |  6 +-
  drivers/gpu/drm/i915/display/intel_display.c  |  8 +-
  drivers/gpu/drm/i915/display/intel_display.h  |  2 +-
  .../drm/i915/display/intel_display_debugfs.c  | 84 +++++++++++++++++++
  .../drm/i915/display/intel_display_types.h    |  4 +-
  drivers/gpu/drm/i915/display/intel_dp.c       | 81 +++++++++++-------
  drivers/gpu/drm/i915/display/intel_dp_mst.c   | 32 ++++---
  drivers/gpu/drm/i915/display/intel_fdi.c      |  2 +-
  .../i915/display/intel_fractional_helper.h    | 36 ++++++++
  .../gpu/drm/i915/display/intel_qp_tables.c    |  3 -
  drivers/gpu/drm/i915/display/intel_vdsc.c     | 30 +++++--
  include/drm/display/drm_dp_helper.h           |  1 +
  16 files changed, 276 insertions(+), 74 deletions(-)
  create mode 100644 drivers/gpu/drm/i915/display/intel_fractional_helper.h





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux