On Tue, 26 Sep 2023, Lee Jones wrote: > On Tue, 26 Sep 2023, Uwe Kleine-König wrote: > > > Hello, > > > > On Wed, Mar 22, 2023 at 09:51:29AM +0100, Uwe Kleine-König wrote: > > > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > > > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > > > the PWM any more. However this is necessary to suspend, because PWM > > > drivers usually refuse to suspend if they are still enabled. > > > > > > Also adapt shutdown to disable the PWM for similar reasons. > > > > > > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle") > > > Reported-by: Aisheng Dong <aisheng.dong@xxxxxxx> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > > This patch was never applied but I think it is still needed. I assume it > > fell through the cracks? > > This "patch" was sent half way through a thread and when opened in my > mail client looks like a mail reply due to the quotes below the '---'. > > I'd suggest sending this again. You also have a copy/paste error in the subject line. -- Lee Jones [李琼斯]