Hi, On Sun, Sep 24, 2023 at 10:47 PM Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx> wrote: > > Hi Doug, > > On Fri, Sep 22, 2023 at 08:44:16AM -0700, Doug Anderson wrote: > > Hi, > > > > On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu > > <laurentiu.palcu@xxxxxxxxxxx> wrote: > > > > > > Hi, > > > > > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > > > > Based on grepping through the source code this driver appears to be > > > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > > > time. Among other things, this means that if a panel is in use that it > > > > won't be cleanly powered off at system shutdown time. > > > > > > > > The fact that we should call drm_atomic_helper_shutdown() in the case > > > > of OS shutdown/restart comes straight out of the kernel doc "driver > > > > instance overview" in drm_drv.c. > > > > > > > > Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx> > > > > Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx> > > > > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > > > > > No issues found on i.MX8MQ. > > > > > > Tested-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx> > > > Reviewed-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx> > > > > Thanks! Would you expect this patch to land through drm-misc? If so, > > I'm happy to commit it there with your tags. > > Yes, please do. The i.MX8MQ DCSS patches go through drm-misc. OK, landed in drm-misc-next: 89755ee1d593 drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time > > If patches to this driver normally flow through drm-misc, I'm also > > happy to post a patch to MAINTAINERS (or review a patch you post) > > adding this to the entry for "NXP i.MX 8MQ DCSS DRIVER": > > > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > > ...which would make it obvious in the future that things should land > > through drm-misc. > > Thanks, that sounds good. https://lore.kernel.org/r/20230925154929.1.I3287e895ce8e68d41b458494a49a1b5ec5c71013@changeid
