Hi, On Fri, Sep 1, 2023 at 4:40 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote: > > Based on grepping through the source code, this driver appears to be > missing a call to drm_atomic_helper_shutdown() at remove time. Let's > add it. > > The fact that we should call drm_atomic_helper_shutdown() in the case > of OS driver remove comes straight out of the kernel doc "driver > instance overview" in drm_drv.c. > > Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > This commit is only compile-time tested. > > NOTE: I'm not 100% sure this is the correct thing to do, but I _think_ > so. Please shout if you know better. > > drivers/gpu/drm/solomon/ssd130x.c | 1 + > 1 file changed, 1 insertion(+) Landed this to drm-misc-next. Since I wasn't 100% sure, if someone finds that this is bad after-the-fact, we can certainly revert. 10c8204c8b17 drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time
