On 9/12/23 09:08, José Pekkarinen wrote: > The removed line prevents the following cleanup function > to execute a dma_fence_put on the out_fence to free its > memory, producing the following output in kmemleak: > > unreferenced object 0xffff888126d8ee00 (size 128): > comm "kwin_wayland", pid 981, jiffies 4295380296 (age 390.060s) > hex dump (first 32 bytes): > c8 a1 c2 27 81 88 ff ff e0 14 a9 c0 ff ff ff ff ...'............ > 30 1a e1 2e a6 00 00 00 28 fc 5b 17 81 88 ff ff 0.......(.[..... > backtrace: > [<0000000011655661>] kmalloc_trace+0x26/0xa0 > [<0000000055f15b82>] virtio_gpu_fence_alloc+0x47/0xc0 [virtio_gpu] > [<00000000fa6d96f9>] virtio_gpu_execbuffer_ioctl+0x1a8/0x800 [virtio_gpu] > [<00000000e6cb5105>] drm_ioctl_kernel+0x169/0x240 [drm] > [<000000005ad33e27>] drm_ioctl+0x399/0x6b0 [drm] > [<00000000a19dbf65>] __x64_sys_ioctl+0xc5/0x100 > [<0000000011fa801e>] do_syscall_64+0x5b/0xc0 > [<0000000065c76d8a>] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > unreferenced object 0xffff888121930500 (size 128): > comm "kwin_wayland", pid 981, jiffies 4295380313 (age 390.096s) > hex dump (first 32 bytes): > c8 a1 c2 27 81 88 ff ff e0 14 a9 c0 ff ff ff ff ...'............ > f9 ec d7 2f a6 00 00 00 28 fc 5b 17 81 88 ff ff .../....(.[..... > backtrace: > [<0000000011655661>] kmalloc_trace+0x26/0xa0 > [<0000000055f15b82>] virtio_gpu_fence_alloc+0x47/0xc0 [virtio_gpu] > [<00000000fa6d96f9>] virtio_gpu_execbuffer_ioctl+0x1a8/0x800 [virtio_gpu] > [<00000000e6cb5105>] drm_ioctl_kernel+0x169/0x240 [drm] > [<000000005ad33e27>] drm_ioctl+0x399/0x6b0 [drm] > [<00000000a19dbf65>] __x64_sys_ioctl+0xc5/0x100 > [<0000000011fa801e>] do_syscall_64+0x5b/0xc0 > [<0000000065c76d8a>] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > [...] > > This memleak will grow quickly, being possible to see the > following line in dmesg after few minutes of life in the > virtual machine: > > [ 706.217388] kmemleak: 10731 new suspected memory leaks (see /sys/kernel/debug/kmemleak) > > The patch will remove the line to allow the cleanup > function do its job. > > Signed-off-by: José Pekkarinen <jose.pekkarinen@xxxxxxxxxxx> > --- > drivers/gpu/drm/virtio/virtgpu_submit.c | 1 - > 1 file changed, 1 deletion(-) Added fixes tag and pushed to misc-fixes -- Best regards, Dmitry
