Re: [PATCH 2/8] drm/format-helper: Pass xfrm buffer to format-conversion helpers

[Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>]

On Wed, 20 Sep 2023, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
> diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
> index 1a6bd291345de..c6deabb6c64e5 100644
> --- a/drivers/gpu/drm/tests/drm_format_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
> @@ -20,6 +20,10 @@
>  
>  #define TEST_USE_DEFAULT_PITCH 0
>  
> +static unsigned char conversion_buf_mem[PAGE_SIZE];
> +static struct drm_xfrm_buf xfrm =
> +	DRM_XFRM_BUF_INIT_PREALLOCATED(conversion_buf_mem, ARRAY_SIZE(conversion_buf_mem));
> +

Just something that caught my eye, that should be sizeof() instead of
ARRAY_SIZE(), I think, even though makes no difference for unsigned
char.

BR,
Jani.


-- 
Jani Nikula, Intel