On Sat, 2023-09-09 at 15:38 -0700, Teres Alexis, Alan Previn wrote: > Update the max GSC-fw response time to match updated internal > fw specs. Because this response time is an SLA on the firmware, > not inclusive of i915->GuC->HW handoff latency, when submitting > requests to the GSC fw via intel_gsc_uc_heci_cmd_submit helpers, > start the count after the request hits the GSC command streamer. > Also, move GSC_REPLY_LATENCY_MS definition from pxp header to > intel_gsc_uc_heci_cmd_submit.h since its for any GSC HECI packet. > > Signed-off-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > --- > .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 20 +++++++++++++++++-- > .../i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h | 6 ++++++ > drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.h | 11 ++++++---- > 3 files changed, 31 insertions(+), 6 deletions(-) alan: snip > index 09d3fbdad05a..5ae5c5d9608b 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h > +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.h > @@ -12,6 +12,12 @@ struct i915_vma; > struct intel_context; > struct intel_gsc_uc; > > +#define GSC_HECI_REPLY_LATENCY_MS 350 > +/* > + * Max FW response time is 350ms, but this should be counted from the time the > + * command has hit the GSC-CS hardware, not the preceding handoff to GuC CTB. > + */ alan: continue to face timeout issues - so increasing this to ~500 to absorb other hw/sw system latencies. this also matches what the gsc-proxy code was doing - so i could use the same macro for that other code path.
