On 9/11/23 10:38, Pekka Paalanen wrote: > On Fri, 8 Sep 2023 17:10:46 +0200 > Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: >> Am 08.09.23 um 16:41 schrieb Pekka Paalanen: >>> On Fri, 8 Sep 2023 15:56:51 +0200 >>> Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: >>>> >>>> I have a number of concerns. My point it not that we shouldn't optimize. >>>> I just don't want it in the kernel. Mgag200 can export DRM_FORMAT_RGB888 >>>> for userspace to use. >>>> >>>> AFAICT the main argument against userspace is that Mesa doesn't like >>>> 3-byte pixels. But I don't see how this conversion cannot be a >>>> post-processing step within Mesa: do the rendering in RGB32 and then >>>> convert to a framebuffer in RGB24. Even assuming the conversion could be handled transparently in Mesa, it would still require the KMS client to pick RGB888 instead of XRGB8888. Most (all?) KMS clients support XRGB8888, many of them will realistically never support RGB888. (Or even if they did, they might prefer XRGB8888 anyway, if RGB888 requires a final conversion step) >>>> Another point of concern is CPU consumption: Slow I/O buses may stall >>>> the display thread, but the CPU could do something else in the meantime. >>>> Doing format conversion on the CPU prevents that, hence affecting other >>>> parts of the system negatively. Of course, that's more of a gut feeling >>>> than hard data. Jocelyn, have you measured if the XRGB8888 -> RGB888 conversion copy takes longer than a straight RGB888 -> RGB888 copy in the kernel? -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer
