Hi Javier Am 06.09.23 um 11:54 schrieb Javier Martinez Canillas:
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:The fbcon module takes care of displaying the logo, if any. Remove the code form mmpfb. If we want to display the logo without fbcon,s/form/fromwe should implement this in the fbdev core code.The commit message says the same than patch #1 but the driver will behave differently right? That is, won't only show the logo when fbcon is not enabled but unconditionally? So the logo will be duplicated when fbcon is enabled? If I understood that correctly, probably you should mention that in the commit message since removing the fb_show_logo() will make the driver to behave correctly.
TBH I don't understand what happens here if the console and the logo has been enabled at the same time. AFAIK fbcon respects display rotation, but this driver doesn't. So the logo shows up in the wrong place then?
Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> ---Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
