Hi, On Thu, Aug 31, 2023 at 1:10 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > This patch is based on commit c9e358dfc4a8 ("driver-core: remove > conditionals around devicetree pointers"). > > Having conditional around the of_node pointer of the drm_bridge > structure turns out to make driver code use ugly #ifdef blocks. Drop the > conditionals to simplify drivers. While this slightly increases the size > of struct drm_bridge on non-OF system, the number of bridges used today > and foreseen tomorrow on those systems is very low, so this shouldn't be > an issue. > > So drop #if conditionals by adding struct device_node forward declaration. > > Suggested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > v5->v6: > * Updated commit description. > * Added Rb tag from Douglas Anderson and Laurent > v5: > * Split from patch#2 > * Updated commit description > * Added struct device_node forward declaration. > --- > include/drm/drm_bridge.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think this has had enough time to marinate, so landed to drm-misc-next: d8dfccde2709 drm/bridge: Drop conditionals around of_node pointers