On Thu, 31 Aug 2023 at 20:04, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, 31 Aug 2023 at 11:48, Sudip Mukherjee (Codethink) > <sudipm.mukherjee@xxxxxxxxx> wrote: > > The latest mainline kernel branch fails to build mips jazz_defconfig with > > the error: > > > > drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'? > > 115 | FB_DEFAULT_IOMEM_HELPERS, > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > | FB_DEFAULT_IOMEM_OPS > > > > > > git bisect pointed to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers"). > > > > Reverting the commit has fixed the build failure. > > > > I will be happy to test any patch or provide any extra log if needed. > > Would you mind testing the exact thing that the compiler suggested? > > So instead of the revert, just replace FB_DEFAULT_IOMEM_HELPERS with > FB_DEFAULT_IOMEM_OPS. > > I think it's just a typo / confusion with the config variable (which > is called FB_IOMEM_HELPERS). Yeah, you were right. Patch sent - https://lore.kernel.org/lkml/20230902095102.5908-1-sudip.mukherjee@xxxxxxxxxxxxxxx/ -- Regards Sudip