Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 3/3] drm/bridge/analogix/anx78xx: Drop conditionals > around of_node pointers > > Hi Biju, > > Thank you for the patch. > > On Wed, Aug 30, 2023 at 06:08:19PM +0100, Biju Das wrote: > > Having conditional around the of_node pointers turns out to make > > driver code use ugly #ifdef and #if blocks. So drop the conditionals. > > How about doing this for all bridge drivers in one go ? I will send separate patch for that one later. Will send V6 with changes suggested for patch#2 first and then will investigate creating patch for dropping conditionals for remaining bridge drivers. Cheers, Biju > > > Suggested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > v5: > > * Split from patch#2 > > --- > > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > index 6169db73d2fe..ad8241758896 100644 > > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > @@ -1231,9 +1231,7 @@ static int anx78xx_i2c_probe(struct i2c_client > > *client) > > > > mutex_init(&anx78xx->lock); > > > > -#if IS_ENABLED(CONFIG_OF) > > anx78xx->bridge.of_node = client->dev.of_node; -#endif > > > > anx78xx->client = client; > > i2c_set_clientdata(client, anx78xx); > > -- > Regards, > > Laurent Pinchart
