On Mon, Aug 28, 2023 at 02:17:02PM +0300, Andy Shevchenko wrote: > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > Having conditional around the of_node pointers turns out to make driver > > code use ugly #ifdef and #if blocks. So drop the conditionals. > > ... > > > -#ifdef CONFIG_OF > > /** @of_node: device node pointer to the bridge */ > > struct device_node *of_node; > > -#endif > > This simply has to be struct fwnode_handle to begin with. > Can you convert the driver to use it? While that's possibly a good idea, it will require touching all the bridge drivers that set this field, so I think it could be done separately. -- Regards, Laurent Pinchart