Re: [PATCH 02/10] drm/tests: Add parameters to the drm_test_framebuffer_create test

[Maíra Canal <mairacanal@xxxxxxxxxx>]

Hi Carlos,

On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote:
> Extend the existing test case to cover:
> 1. Invalid flag atribute in the struct drm_mode_fb_cmd2.
> 2. Pixel format which requires non-linear modifier with
> DRM_FORMAT_MOD_LINEAR set.
> 3. Non-zero buffer offset for an unused plane
>
> Also replace strcpy to strscpy on test_to_desc for improved security
> and reliability.
>
> Signed-off-by: Carlos Eduardo Gallo Filho <gcarlos@xxxxxxxxxxx>
> ---
>   drivers/gpu/drm/tests/drm_framebuffer_test.c | 23 +++++++++++++++++++-
>   1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> index 173d42b145ed..aeaf2331f9cc 100644
> --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
> +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> @@ -19,6 +19,8 @@
>   #define MIN_HEIGHT 4
>   #define MAX_HEIGHT 4096
>   
> +#define DRM_MODE_FB_INVALID BIT(2)
> +
>   struct drm_framebuffer_test {
>   	int buffer_created;
>   	struct drm_mode_fb_cmd2 cmd;
> @@ -83,6 +85,18 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
>   		 .pitches = { 4 * MAX_WIDTH, 0, 0 },
>   	}
>   },
> +{ .buffer_created = 0, .name = "ABGR8888 Non-zero buffer offset for unused plane",
> +	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
> +		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, UINT_MAX / 2, 0 },
> +		 .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,
> +	}
> +},
> +{ .buffer_created = 0, .name = "ABGR8888 Invalid flag",
> +	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
> +		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
> +		 .pitches = { 4 * MAX_WIDTH, 0, 0 }, .flags = DRM_MODE_FB_INVALID,
> +	}
> +},
>   { .buffer_created = 1, .name = "ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers",
>   	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_ABGR8888,
>   		 .handles = { 1, 0, 0 }, .offsets = { UINT_MAX / 2, 0, 0 },
> @@ -262,6 +276,13 @@ static const struct drm_framebuffer_test drm_framebuffer_create_cases[] = {
>   		 .pitches = { MAX_WIDTH, DIV_ROUND_UP(MAX_WIDTH, 2), DIV_ROUND_UP(MAX_WIDTH, 2) },
>   	}
>   },
> +{ .buffer_created = 0, .name = "YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)",
> +	.cmd = { .width = MAX_WIDTH, .height = MAX_HEIGHT, .pixel_format = DRM_FORMAT_YUV420_10BIT,
> +		 .handles = { 1, 0, 0 }, .flags = DRM_MODE_FB_MODIFIERS,
> +		 .modifier = { DRM_FORMAT_MOD_LINEAR, 0, 0 },
> +		 .pitches = { MAX_WIDTH, 0, 0 },
> +	}
> +},
>   { .buffer_created = 1, .name = "X0L2 Normal sizes",
>   	.cmd = { .width = 600, .height = 600, .pixel_format = DRM_FORMAT_X0L2,
>   		 .handles = { 1, 0, 0 }, .pitches = { 1200, 0, 0 }
> @@ -369,7 +390,7 @@ static void drm_test_framebuffer_create(struct kunit *test)
>   
>   static void drm_framebuffer_test_to_desc(const struct drm_framebuffer_test *t, char *desc)
>   {
> -	strcpy(desc, t->name);
> +	strscpy(desc, t->name, KUNIT_PARAM_DESC_SIZE);
I believe this change should be done in a separate patch.

Best Regards,
- Maíra

>   }
>   
>   KUNIT_ARRAY_PARAM(drm_framebuffer_create, drm_framebuffer_create_cases,