On Fri, Aug 25, 2023 at 06:48:45AM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 9:26 PM Laurent Pinchart wrote: > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > ... > > > I wonder, as the device can only be instantiated from OF, should we add > > > > depends on OF > > Generally speaking this is a bad idea. It prevents a component from > being instantiated on ACPI based systems (even if there is no ACPI ID > table, due to a gateway called PRP0001). I'd be surprised if there were systems were that would work out of the box for this particular driver, so we could always drop the dependency when someone updates the driver to work on ACPI-based systems. I'm however not pushing to add the dependency though. > > to Kconfig, and drop the > > > > #if IS_ENABLED(CONFIG_OF) > > > > from the driver ? > > Contrary this is an idea I fully support! > > -- > With Best Regards, > Andy Shevchenko -- Regards, Laurent Pinchart
