Hi Laurent Pinchart,
Thanks for the feedback.
> Subject: Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table
>
> Hi Biju,
>
> Thank you for the patch.
>
> On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote:
> > The driver has an ID table, but it uses the wrong API for retrieving
> > match data and that will lead to a crash, if it is instantiated by
> > user space or using ID. From this, there is no user for the ID table
> > and let's drop it from the driver as it saves some memory.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> I wonder, as the device can only be instantiated from OF, should we add
>
> depends on OF
>
> to Kconfig, and drop the
>
> #if IS_ENABLED(CONFIG_OF)
>
> from the driver ?
OK, will send a separate patch for this, if there
is no objection.
Cheers,
Biju
>
> > ---
> > v2->v3:
> > * Updated commit header.
> > v1->v2:
> > * Dropped ID table support.
> > ---
> > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> > b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> > index 800555aef97f..6169db73d2fe 100644
> > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c
> > @@ -1367,12 +1367,6 @@ static void anx78xx_i2c_remove(struct i2c_client
> *client)
> > kfree(anx78xx->edid);
> > }
> >
> > -static const struct i2c_device_id anx78xx_id[] = {
> > - { "anx7814", 0 },
> > - { /* sentinel */ }
> > -};
> > -MODULE_DEVICE_TABLE(i2c, anx78xx_id);
> > -
> > static const struct of_device_id anx78xx_match_table[] = {
> > { .compatible = "analogix,anx7808", .data = anx7808_i2c_addresses },
> > { .compatible = "analogix,anx7812", .data = anx781x_i2c_addresses },
> > @@ -1389,7 +1383,6 @@ static struct i2c_driver anx78xx_driver = {
> > },
> > .probe = anx78xx_i2c_probe,
> > .remove = anx78xx_i2c_remove,
> > - .id_table = anx78xx_id,
> > };
> > module_i2c_driver(anx78xx_driver);
> >
>
> --
> Regards,
>
> Laurent Pinchart
