RE: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Doug Anderson,

> Subject: Re: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support
> for ID table
> 
> Hi,
> 
> On Sun, Aug 13, 2023 at 1:51 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> >
> > The driver has ID  table, but still it uses device_get_match_data()
> > for retrieving match data. Replace device_get_match_data->
> > i2c_get_match_data() for retrieving OF/ACPI/I2C match data by adding
> > match data for ID table similar to OF table.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > This patch is only compile tested
> > ---
> >  drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> It seems like this is a sign that nobody is actually using the i2c match
> table. It was probably added because the original author just copy/pasted
> from something else, but obviously it hasn't been kept up to date and isn't
> working. While your patch would make it work for "anx7814", it wouldn't
> make it work for any of the other similar parts. ...and yes, you could add
> support for those parts in your patch too, but IMO it makes more sense to
> just delete the i2c table and when someone has an actual need then they can
> re-add it.
> 
> Sound OK?

Yes, it make sense, as it saves some memory.

Cheers,
Biju




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux