On 16/08/2023 14:25, Tomi Valkeinen wrote: > This series contains various fixes and cleanups for TC358768. The target > of this work is to get TC358768 working on Toradex's AM62 based board, > which has the following display pipeline: > > AM62 DPI -> TC358768 -> LT8912B -> HDMI connector > > The main thing the series does is to improve the DSI HSW, HFP and VSDly > calculations. Thanks Tomi for the updates, I cannot test it or verify against the datasheet, but codewise the series looks nice: Reviewed-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> > > Tomi > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > --- > Changes in v2: > - Add "drm/tegra: rgb: Parameterize V- and H-sync polarities" so that > Tegra can configure the polarities correctly. > - Add "drm/bridge: tc358768: Default to positive h/v syncs" as we don't > (necessarily) have the polarities set in the mode. > - Drop "drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR > support" as it's not needed for DRM_BRIDGE_ATTACH_NO_CONNECTOR > support. > - Link to v1: https://lore.kernel.org/r/20230804-tc358768-v1-0-1afd44b7826b@xxxxxxxxxxxxxxxx > > --- > Thierry Reding (1): > drm/tegra: rgb: Parameterize V- and H-sync polarities > > Tomi Valkeinen (11): > drm/bridge: tc358768: Fix use of uninitialized variable > drm/bridge: tc358768: Fix bit updates > drm/bridge: tc358768: Cleanup PLL calculations > drm/bridge: tc358768: Use struct videomode > drm/bridge: tc358768: Print logical values, not raw register values > drm/bridge: tc358768: Use dev for dbg prints, not priv->dev > drm/bridge: tc358768: Rename dsibclk to hsbyteclk > drm/bridge: tc358768: Clean up clock period code > drm/bridge: tc358768: Fix tc358768_ns_to_cnt() > drm/bridge: tc358768: Attempt to fix DSI horizontal timings > drm/bridge: tc358768: Default to positive h/v syncs > > drivers/gpu/drm/bridge/tc358768.c | 381 ++++++++++++++++++++++++++++---------- > drivers/gpu/drm/tegra/rgb.c | 16 +- > 2 files changed, 295 insertions(+), 102 deletions(-) > --- > base-commit: 4d49d87b3606369c6e29b9d051892ee1a6fc4e75 > change-id: 20230804-tc358768-1b6949ef2e3d > > Best regards, -- Péter
