Re: [PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

On Mon, Aug 21, 2023 at 11:34 AM Christian König
<christian.koenig@xxxxxxx> wrote:
> Am 21.08.23 um 11:14 schrieb Geert Uytterhoeven:
> > On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> >> On Fri, Jul 7, 2023 at 2:06 PM Christian König
> >> <ckoenig.leichtzumerken@xxxxxxxxx> wrote:
> >>> Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven:
> >>>> On 32-bit:
> >>>>
> >>>>       ../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’:
> >>>>       ../tests/amdgpu/amdgpu_stress.c:178:49: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Wformat=]
> >>>>         fprintf(stdout, "Allocated BO number %u at 0x%lx, domain 0x%x, size %lu\n",
> >>>>                                                      ~~^
> >>>>                                                      %llx
> >>>>          num_buffers++, addr, domain, size);
> >>>>                         ~~~~
> >> [...]
> >>
> >>>> Fix this by using the proper "PRI?64" format specifiers.
> >>>>
> >>>> Fixes: d77ccdf3ba6f5a39 ("amdgpu: add amdgpu_stress utility v2")
> >>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >>> Well generally good patch, but libdrm changes are now reviewed by merge
> >>> request and not on the mailing list any more.
> >> I heard such a rumor, too ;-)
> >>
> >> Unfortunately one year later, that process is still not documented in
> >> https://gitlab.freedesktop.org/mesa/drm/-/blob/main/CONTRIBUTING.rst
> >> which still instructs me (a casual drive-by developer) to just submit
> >> my patches to the mailing list...
> > So a few weeks ago I created gitlab PRs for all my pending libdrm
> > patch series, and I rebased them regularly when needed.
> > What needs to be done to get them merged?
>
> You need to ping the userspace maintainers for this. Like Marek,
> Pierre-Eric etc..

Thanks, I assume (from "git shortlog") you mean Marek Olšák and
Pierre-Eric Pelloux-Prayer?
How do I find out the maintainers for non-amd parts?

Looks like this thread is becoming a "what is missing in
CONTRIBUTING.rst?" list ;-)

Thanks again!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux