From: Intel-xe <intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx>
On Behalf Of Zeng, Oak
Sent: August 14, 2023 11:38 PM
To: Thomas Hellström <thomas.hellstrom@xxxxxxxxxxxxxxx>; Brost, Matthew <matthew.brost@xxxxxxxxx>; Vishwanathapura, Niranjana <niranjana.vishwanathapura@xxxxxxxxx>; Welty, Brian <brian.welty@xxxxxxxxx>; Felix Kuehling <felix.kuehling@xxxxxxx>; Philip
Yang <Philip.Yang@xxxxxxx>; intel-xe@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx
Subject: [Intel-xe] Implement svm without BO concept in xe driver
Hi Thomas, Matt and all,
This came up when I port i915 svm codes to xe driver. In i915 implementation, we have i915_buddy manage gpu vram and svm codes directly call i915_buddy layer to allocate/free vram. There is no gem_bo/ttm bo concept involved in the svm implementation.
In xe driver, we have drm_buddy, xe_ttm_vram_mgr and ttm layer to manage vram. Drm_buddy is initialized during xe_ttm_vram_mgr initialization. Vram allocation/free is done through xe_ttm_vram_mgr functions which call into drm_buddy layer
to allocate vram blocks.
I plan to implement xe svm driver the same way as we did in i915, which means there will not be bo concept in the svm implementation. Drm_buddy will be passed to svm layer during vram initialization and svm will allocate/free memory directly
from drm_buddy, bypassing ttm/xee vram manager. Here are a few considerations/things we are aware of:
- This approach seems match hmm design better than bo concept. Our svm implementation will be based on hmm. In hmm design, each vram page is backed by a struct page. It is very easy
to perform page granularity migrations (b/t vram and system memory). If BO concept is involved, we will have to split/remerge BOs during page granularity migrations.
- We have a prove of concept of this approach in i915, originally implemented by Niranjana. It seems work but it only has basic functionalities for now. We don’t have advanced features
such as memory eviction etc.
- With this approach, vram will divided into two separate pools: one for xe_gem_created BOs and one for vram used by svm. Those two pools are not connected: memory pressure from one
pool won’t be able to evict vram from another pool. At this point, we don’t whether this aspect is good or not.
- Amdkfd svm went different approach which is BO based. The benefit of this approach is a lot of existing driver facilities (such as memory eviction/cgroup/accounting) can be reused
Do you have any comment to this approach? Should I come back with a RFC of some POC codes?
Thanks,
Oak
