On 04/08/2023 13:44, Tomi Valkeinen wrote:
> smatch reports:
>
> drivers/gpu/drm/bridge/tc358768.c:223 tc358768_update_bits() error: uninitialized symbol 'orig'.
>
> Fix this by bailing out from tc358768_update_bits() if the
> tc358768_read() produces an error.
>
> Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/tc358768.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c
> index 819a4b6ec2a0..bc97a837955b 100644
> --- a/drivers/gpu/drm/bridge/tc358768.c
> +++ b/drivers/gpu/drm/bridge/tc358768.c
> @@ -216,6 +216,10 @@ static void tc358768_update_bits(struct tc358768_priv *priv, u32 reg, u32 mask,
> u32 tmp, orig;
>
> tc358768_read(priv, reg, &orig);
> +
no need for blank line
> + if (priv->error)
> + return;
> +
> tmp = orig & ~mask;
> tmp |= val & mask;
> if (tmp != orig)
>
--
Péter
