Re: [PATCH] drm: xlnx: Use devm_platform_ioremap_resource_byname() helper function

["zhangzekun (A)" <zhangzekun11@xxxxxxxxxx>]

I am sorry for make noise, this patch has been sent  before:

https://lore.kernel.org/linux-arm-kernel/20230801214729.GF8578@xxxxxxxxxxxxxxxxxxxxxxxxxx/T/

Please ignore this patch.

在 2023/8/11 10:11, Zhang Zekun 写道:
> platform_get_resource_byname() and devm_ioremap_resource() can be
> replaced by devm_platform_ioremap_resource_byname(), which can
> simplify the code logic a bit, No functional change here.
>
> Signed-off-by: Zhang Zekun <zhangzekun11@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/xlnx/zynqmp_disp.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 3b87eebddc97..2b731f3eea54 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -1228,7 +1228,6 @@ int zynqmp_disp_probe(struct zynqmp_dpsub *dpsub)
>   {
>   	struct platform_device *pdev = to_platform_device(dpsub->dev);
>   	struct zynqmp_disp *disp;
> -	struct resource *res;
>   	int ret;
>   
>   	disp = kzalloc(sizeof(*disp), GFP_KERNEL);
> @@ -1238,22 +1237,19 @@ int zynqmp_disp_probe(struct zynqmp_dpsub *dpsub)
>   	disp->dev = &pdev->dev;
>   	disp->dpsub = dpsub;
>   
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "blend");
> -	disp->blend.base = devm_ioremap_resource(disp->dev, res);
> +	disp->blend.base = devm_platform_ioremap_resource_byname(pdev, "blend");
>   	if (IS_ERR(disp->blend.base)) {
>   		ret = PTR_ERR(disp->blend.base);
>   		goto error;
>   	}
>   
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "av_buf");
> -	disp->avbuf.base = devm_ioremap_resource(disp->dev, res);
> +	disp->avbuf.base = devm_platform_ioremap_resource_byname(pdev, "av_buf");
>   	if (IS_ERR(disp->avbuf.base)) {
>   		ret = PTR_ERR(disp->avbuf.base);
>   		goto error;
>   	}
>   
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "aud");
> -	disp->audio.base = devm_ioremap_resource(disp->dev, res);
> +	disp->audio.base = devm_platform_ioremap_resource_byname(pdev, "aud");
>   	if (IS_ERR(disp->audio.base)) {
>   		ret = PTR_ERR(disp->audio.base);
>   		goto error;