Hi,
On Tue, Aug 08, 2023 at 11:02:45AM -0700, Nikita Zhandarovich wrote:
> Four hdmi_*_infoframe_init() functions that initialize different
> types of hdmi infoframes only return the default 0 value, contrary to
> their descriptions. Yet these functions are still unnecessarily checked
> against possible errors in case of failure.
>
> Remove redundant error checks in calls to following functions:
> - hdmi_spd_infoframe_init
> - hdmi_audio_infoframe_init
> - hdmi_vendor_infoframe_init
> - hdmi_drm_infoframe_init
> Also, convert these functions to 'void' and fix their descriptions.
I'm not sure what value it actually adds. None of them return any
errors, but very well might if we started to be a bit serious about it.
Since the error handling is already there, then I'd rather leave it
there.
> Fixes: 2c676f378edb ("[media] hdmi: added unpack and logging functions for InfoFrames")
I'm confused about that part. What does it fix exactly?
Maxime
Attachment:
signature.asc
Description: PGP signature
