Applied. Thanks! On Mon, Jul 31, 2023 at 11:03 PM Ran Sun <sunran001@xxxxxxxxxx> wrote: > > Fix the following errors reported by checkpatch: > > ERROR: return is not a function, parentheses are not required > ERROR: space required after that ',' (ctx:VxV) > ERROR: space required before the open parenthesis '(' > ERROR: need consistent spacing around '-' (ctx:WxV) > > Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx> > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h > index dac29fe6cfc6..6f54c410c2f9 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppevvmath.h > @@ -166,7 +166,7 @@ static fInt fNaturalLog(fInt value) > > error_term = fAdd(fNegativeOne, value); > > - return (fAdd(solution, error_term)); > + return fAdd(solution, error_term); > } > > static fInt fDecodeLinearFuse(uint32_t fuse_value, fInt f_min, fInt f_range, uint32_t bitlength) > @@ -230,7 +230,7 @@ static fInt ConvertToFraction(int X) /*Add all range checking here. Is it possib > static fInt fNegate(fInt X) > { > fInt CONSTANT_NEGONE = ConvertToFraction(-1); > - return (fMultiply(X, CONSTANT_NEGONE)); > + return fMultiply(X, CONSTANT_NEGONE); > } > > static fInt Convert_ULONG_ToFraction(uint32_t X) > @@ -382,14 +382,14 @@ static int ConvertBackToInteger (fInt A) /*THIS is the function that will be use > > scaledDecimal.full = uGetScaledDecimal(A); > > - fullNumber = fAdd(scaledDecimal,scaledReal); > + fullNumber = fAdd(scaledDecimal, scaledReal); > > return fullNumber.full; > } > > static fInt fGetSquare(fInt A) > { > - return fMultiply(A,A); > + return fMultiply(A, A); > } > > /* x_new = x_old - (x_old^2 - C) / (2 * x_old) */ > @@ -447,7 +447,7 @@ static fInt fSqrt(fInt num) > > } while (uAbs(error) > 0); > > - return (x_new); > + return x_new; > } > > static void SolveQuadracticEqn(fInt A, fInt B, fInt C, fInt Roots[]) > @@ -459,7 +459,7 @@ static void SolveQuadracticEqn(fInt A, fInt B, fInt C, fInt Roots[]) > f_CONSTANT100 = ConvertToFraction(100); > f_CONSTANT10 = ConvertToFraction(10); > > - while(GreaterThan(A, f_CONSTANT100) || GreaterThan(B, f_CONSTANT100) || GreaterThan(C, f_CONSTANT100)) { > + while (GreaterThan(A, f_CONSTANT100) || GreaterThan(B, f_CONSTANT100) || GreaterThan(C, f_CONSTANT100)) { > A = fDivide(A, f_CONSTANT10); > B = fDivide(B, f_CONSTANT10); > C = fDivide(C, f_CONSTANT10); > @@ -515,7 +515,7 @@ static int uGetScaledDecimal (fInt A) /*Converts the fractional portion to whole > dec[i] = tmp / (1 << SHIFT_AMOUNT); > tmp = tmp - ((1 << SHIFT_AMOUNT)*dec[i]); > tmp *= 10; > - scaledDecimal = scaledDecimal + dec[i]*uPow(10, PRECISION - 1 -i); > + scaledDecimal = scaledDecimal + dec[i]*uPow(10, PRECISION - 1 - i); > } > > return scaledDecimal; > -- > 2.17.1 >