On Wed, Aug 02, 2023 at 03:42:04PM +0800, Zhu Wang wrote: > The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF > and of_match_ptr() here, we remove them all. > > Even for drivers that do not depend on CONFIG_OF, it's almost always > better to leave out the of_match_ptr(), since the only thing it can > possibly do is to save a few bytes of .text if a driver can be used both > with and without it. > > Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> I haven't given you any tag, why is this line here?! -- With Best Regards, Andy Shevchenko