On 2023-08-02 21:36:55, Dmitry Baryshkov wrote:
> Both struct dpu_dsc_sub_blks instances declare enc subblock length to be
> 0x100, while the actual length is 0x9c (last register having offset 0x98).
> Reduce subblock length to remove the empty register space from being
> dumped.
>
> Fixes: 0d1b10c63346 ("drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets")
> Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>
> Changes since v1:
> - Rebased on top of the catalog changes
>
> ---
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 3ff07d7cbf4b..f1bac5e88249 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -456,12 +456,12 @@ static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = {
> * DSC sub blocks config
> *************************************************************/
> static const struct dpu_dsc_sub_blks dsc_sblk_0 = {
> - .enc = {.name = "enc", .base = 0x100, .len = 0x100},
> + .enc = {.name = "enc", .base = 0x100, .len = 0x9c},
> .ctl = {.name = "ctl", .base = 0xF00, .len = 0x10},
For the time being only ctl register 0x00 and 0x04 is touched,
DATA_IN_SWAP and CLK_CTRL at 0x08 and 0x0c are defined but not used,
though it might still be useful to see their current value in the dump.
- Marijn
> };
>
> static const struct dpu_dsc_sub_blks dsc_sblk_1 = {
> - .enc = {.name = "enc", .base = 0x200, .len = 0x100},
> + .enc = {.name = "enc", .base = 0x200, .len = 0x9c},
> .ctl = {.name = "ctl", .base = 0xF80, .len = 0x10},
> };
>
> --
> 2.39.2
>
