Re: [PATCH 1/6] accel/ivpu: Rename sources to use generation based names

[Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>]

On 7/31/2023 10:12 AM, Stanislaw Gruszka wrote:
> From: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx>
>
> Given that VPU generation can be used by multiple platforms, driver should
> use VPU IP generation in names instead of a platform names.

I think just "platform." instead of "platform names" reads better.

> Change naming for sources files.
>
> Use 37XX format, where:
>    3 - major VPU IP generation version
>    7 - minor VPU IP generation version
>    XX - postfix indicating this is a architecture and not marketing name

"an architecture"

> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>

Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>

> ---
>   drivers/accel/ivpu/Makefile                                  | 2 +-
>   drivers/accel/ivpu/{ivpu_hw_mtl.c => ivpu_hw_37xx.c}         | 2 +-
>   drivers/accel/ivpu/{ivpu_hw_mtl_reg.h => ivpu_hw_37xx_reg.h} | 0
>   drivers/accel/ivpu/ivpu_mmu.c                                | 2 +-
>   4 files changed, 3 insertions(+), 3 deletions(-)
>   rename drivers/accel/ivpu/{ivpu_hw_mtl.c => ivpu_hw_37xx.c} (99%)
>   rename drivers/accel/ivpu/{ivpu_hw_mtl_reg.h => ivpu_hw_37xx_reg.h} (100%)
>
> diff --git a/drivers/accel/ivpu/Makefile b/drivers/accel/ivpu/Makefile
> index 9858d9fea36e..3179e146e173 100644
> --- a/drivers/accel/ivpu/Makefile
> +++ b/drivers/accel/ivpu/Makefile
> @@ -7,7 +7,7 @@ intel_vpu-y := \
>   	ivpu_fw.o \
>   	ivpu_fw_log.o \
>   	ivpu_gem.o \
> -	ivpu_hw_mtl.o \
> +	ivpu_hw_37xx.o \
>   	ivpu_ipc.o \
>   	ivpu_job.o \
>   	ivpu_jsm_msg.o \
> diff --git a/drivers/accel/ivpu/ivpu_hw_mtl.c b/drivers/accel/ivpu/ivpu_hw_37xx.c
> similarity index 99%
> rename from drivers/accel/ivpu/ivpu_hw_mtl.c
> rename to drivers/accel/ivpu/ivpu_hw_37xx.c
> index f1211e74017d..495be81840ac 100644
> --- a/drivers/accel/ivpu/ivpu_hw_mtl.c
> +++ b/drivers/accel/ivpu/ivpu_hw_37xx.c
> @@ -5,7 +5,7 @@
>   
>   #include "ivpu_drv.h"
>   #include "ivpu_fw.h"
> -#include "ivpu_hw_mtl_reg.h"
> +#include "ivpu_hw_37xx_reg.h"
>   #include "ivpu_hw_reg_io.h"
>   #include "ivpu_hw.h"
>   #include "ivpu_ipc.h"
> diff --git a/drivers/accel/ivpu/ivpu_hw_mtl_reg.h b/drivers/accel/ivpu/ivpu_hw_37xx_reg.h
> similarity index 100%
> rename from drivers/accel/ivpu/ivpu_hw_mtl_reg.h
> rename to drivers/accel/ivpu/ivpu_hw_37xx_reg.h
> diff --git a/drivers/accel/ivpu/ivpu_mmu.c b/drivers/accel/ivpu/ivpu_mmu.c
> index 53878e77aad3..b64eb094343b 100644
> --- a/drivers/accel/ivpu/ivpu_mmu.c
> +++ b/drivers/accel/ivpu/ivpu_mmu.c
> @@ -7,7 +7,7 @@
>   #include <linux/highmem.h>
>   
>   #include "ivpu_drv.h"
> -#include "ivpu_hw_mtl_reg.h"
> +#include "ivpu_hw_37xx_reg.h"
>   #include "ivpu_hw_reg_io.h"
>   #include "ivpu_mmu.h"
>   #include "ivpu_mmu_context.h"