Hi,
On 27.07.23 18:50, Thierry Reding wrote:
> On Thu, Jul 27, 2023 at 07:26:28PM +0300, Svyatoslav Ryhel wrote:
>>
>>
>> 27 липня 2023 р. 18:11:15 GMT+03:00, Thierry Reding <thierry.reding@xxxxxxxxx> написав(-ла):
>>> On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote:
>>>> All ASUS Transformers have micro-HDMI connector directly available.
>>>> After Tegra HDMI got bridge/connector support, we should use connector
>>>> framework for proper HW description.
>>>>
>>>> Tested-by: Andreas Westman Dorcsak <hedmoo@xxxxxxxxx> # ASUS TF T30
>>>> Tested-by: Robert Eckelmann <longnoserob@xxxxxxxxx> # ASUS TF101 T20
>>>> Tested-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx> # ASUS TF201 T30
>>>> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
>>>> ---
>>>> arch/arm/boot/dts/tegra20-asus-tf101.dts | 22 ++++++++++++++++---
>>>> .../dts/tegra30-asus-transformer-common.dtsi | 21 ++++++++++++++++--
>>>> 2 files changed, 38 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/tegra20-asus-tf101.dts b/arch/arm/boot/dts/tegra20-asus-tf101.dts
>>>> index c2a9c3fb5b33..97350f566539 100644
>>>> --- a/arch/arm/boot/dts/tegra20-asus-tf101.dts
>>>> +++ b/arch/arm/boot/dts/tegra20-asus-tf101.dts
>>>> @@ -82,9 +82,11 @@ hdmi@54280000 {
>>>> pll-supply = <&hdmi_pll_reg>;
>>>> hdmi-supply = <&vdd_hdmi_en>;
>>>>
>>>> - nvidia,ddc-i2c-bus = <&hdmi_ddc>;
>>>> - nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7)
>>>> - GPIO_ACTIVE_HIGH>;
>>>> + port@0 {
>>>> + hdmi_out: endpoint {
>>>> + remote-endpoint = <&connector_in>;
>>>> + };
>>>> + };
>>>
>>> Does this need a bindings change? nvidia,tegra20-hdmi currently doesn't
>>> support OF graphs, so this would probably fail to validate if we merge
>>> it without a corresponding DT bindings update.
>>
>> drm/tegra patch is backwards compatible and connector node is optional.
>
> We still need to document the connector node, otherwise the DT
> validation will complain about port@0 being used here, won't it?
this change indeed causes several new warnings:
/mnt/linux/.output/arch/arm/boot/dts/tegra20-asus-tf101.dtb: hdmi@54280000: 'port@0' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /mnt/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
/mnt/linux/.output/arch/arm/boot/dts/tegra20-asus-tf101.dtb: hdmi@54280000: 'nvidia,ddc-i2c-bus' is a required property
From schema: /mnt/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
/mnt/linux/.output/arch/arm/boot/dts/tegra20-asus-tf101.dtb: hdmi@54280000: 'nvidia,hpd-gpio' is a required property
From schema: /mnt/linux/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
BTW, the parallel RGB port isn't properly documented in nvidia,tegra20-dc either.
Best regards,
Maxim
