Hi Jason, Daniel Since patchwork puked on v5 just sent, Im calling this v5b. Its also on github remote: Create a pull request for 'dd-fix-5b' on GitHub by visiting: remote: https://github.com/jimc/linux/pull/new/dd-fix-5b remote: To github.com:jimc/linux.git * [new branch] dd-fix-5b -> dd-fix-5b This is V5, Im hoping to land this one. patchwork will probably call this set v3 113361 fix DRM_USE_DYNAMIC_DEBUG regression - revs 1,2 111652 DRM_USE_DYNAMIC_DEBUG regression - older, also 2 revs It (patch 14 mainly): Fixes: aad0214f3026 ("dyndbg: add DECLARE_DYNDBG_CLASSMAP macro") Fixes: f158936b60a7 ("drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.") Ref: commit bb2ff6c27bc9 ("drm: Disable dynamic debug as broken") It replaces DECLARE_DYNDBG_CLASSMAP macro with 2 new ones; DYNDBG_CLASSMAP_DEFINE/_USE, and invokes them from drm.ko and drivers respectively. A new __dyndbg_class_users section contains each driver's _USE; dyndbg scans it at driver-module load, finds drm.debug, and applies it to the driver's class'd prdbgs. The code it fixes went in here: https://lore.kernel.org/lkml/Yy7%2F6oTBW2lqVSK1@xxxxxxxxx/ then Ref: effectively marked DRM_USE_DYNAMIC_DEBUG=y as broken and https://lore.kernel.org/lkml/Y3XUrOGAV4I7bB3M@xxxxxxxxx/ GregKH opined: This should go through the drm tree now. The rest probably should also go that way and not through my tree as well. While most of this patchset's churn is still in lib/, DRM is the real user for all this classmap stuff, and the real acceptance test is in DRM CI. Hopefully it won't fall over in BAT. However, theres also a dyndbg patch to add -s flag, I havent seen it lately, but it might have a nominal conflict. I'll happily take reviews/Acks/tested-bys, grumpily breakage reports. And some landing instructions, wind-speed, runway assignment, etc from the Tower. theres also a few drive-by checkpatch tweaks. 13 fixes a warning that 14 gets about vmlinux.lds.h declared linker-symbols. Jim Cromie (22): drm: use correct ccflags-y syntax test-dyndbg: fixup CLASSMAP usage error dyndbg: make ddebug_class_param union members same size dyndbg: replace classmap list with a vector dyndbg: ddebug_apply_class_bitmap - add module arg, select on it dyndbg: split param_set_dyndbg_classes to module/wrapper fns dyndbg: drop NUM_TYPE_ARRAY dyndbg: reduce verbose/debug clutter dyndbg: silence debugs with no-change updates dyndbg: tighten ddebug_class_name() 1st arg type dyndbg: tighten fn-sig of ddebug_apply_class_bitmap dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code checkpatch: file-scoped extern special case for linker-symbol dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression dyndbg: add for_each_boxed_vector dyndbg: refactor ddebug_classparam_clamp_input dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API dyndbg-test: build it with just CONFIG_DYNAMIC_DEBUG_CORE drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers dyndbg-doc: add classmap info to howto checkpatch: reword long-line warn about commit-msg .../admin-guide/dynamic-debug-howto.rst | 64 ++- MAINTAINERS | 2 +- drivers/gpu/drm/Kconfig | 3 +- drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 +- drivers/gpu/drm/display/drm_dp_helper.c | 12 +- drivers/gpu/drm/drm_crtc_helper.c | 12 +- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 + drivers/gpu/drm/drm_print.c | 35 +- drivers/gpu/drm/gud/gud_drv.c | 2 + drivers/gpu/drm/i915/i915_params.c | 12 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 + drivers/gpu/drm/nouveau/nouveau_drm.c | 12 +- drivers/gpu/drm/qxl/qxl_drv.c | 2 + drivers/gpu/drm/radeon/radeon_drv.c | 2 + drivers/gpu/drm/udl/udl_main.c | 2 + drivers/gpu/drm/vkms/vkms_drv.c | 2 + drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 + include/asm-generic/vmlinux.lds.h | 1 + include/drm/drm_print.h | 12 +- include/linux/dynamic_debug.h | 113 +++-- kernel/module/main.c | 3 + lib/Kconfig.debug | 10 +- lib/Makefile | 4 +- lib/dynamic_debug.c | 406 +++++++++++------- lib/test_dynamic_debug.c | 127 +++--- lib/test_dynamic_debug_submod.c | 10 + scripts/checkpatch.pl | 22 +- 28 files changed, 550 insertions(+), 341 deletions(-) create mode 100644 lib/test_dynamic_debug_submod.c -- 2.41.0
