On Tue, Aug 1, 2023, at 20:00, Andy Shevchenko wrote:
> On Tue, Aug 01, 2023 at 11:32:20AM +0800, Zhu Wang wrote:
>> The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF
>> and of_match_ptr here, we remove them all.
>>
>> Even for drivers that do not depend on CONFIG_OF, it's almost always
>> better to leave out the of_match_ptr(), since the only thing it can
>> possibly do is to save a few bytes of .text if a driver can be used both
>> with and without it.
>
> Instead, you may convert this driver to use device property APIs and make it
> OF-free (okay, almost, with one API that still would be called for OF, but not
> for the rest).
No, there is really no need for that. That can be done if anyone ever
needs this driver to again work with hardwired properties from another
device, or from ACPI, until then this would be a waste of time.
Removing of_match_ptr() on the other hand is useful since it is
a common source of bugs.
Arnd
