On 2023/8/1 0:22, Tom Rix wrote: > > On 7/31/23 6:26 AM, Ruan Jinjie wrote: >> Ther are many ternary operators, the true or false judgement >> of which is unnecessary in C language semantics. >> >> Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx> >> --- > > snip >> data->registry_data.avfs_support = >> - hwmgr->feature_mask & PP_AVFS_MASK ? true : false; >> + hwmgr->feature_mask & PP_AVFS_MASK; >> data->registry_data.led_dpm_enabled = 1; > > These are not equivalent, consider 0xffff & 0x1000 != 1 Sorry! these are actually not equivalent,I'll fix it in v2. But the many others could be more simplified. > > Tom > >