On 2023-07-30 03:22:46, Dmitry Baryshkov wrote: > On 27/07/2023 23:12, Marijn Suijten wrote: > > On 2023-07-27 19:21:01, Dmitry Baryshkov wrote: > >> The DPU_INTF_TE bit is set for all INTF blocks on DPU >= 5.0, however > >> only INTF_1 and INTF_2 actually support tearing control. Rather than > >> trying to fix the DPU_INTF_TE, check for the presense of the > > > > I would more exactly expand "fix" to "Rather than specifying that > > feature bit on DSI INTF_1 and INTF_2 exclusively..." > > > >> corresponding interrupt line. > > > > ... which the catalog will only provide on DPU >= 5.0. > > I'm going to rephrase this in a slightly different way to follow the irq > presence -> major & type change. Sure, looks good, including the validation (that doesn't really need to be mentioned in the commit message anymore). - Marijn
