On 2023-07-27 23:16:22, Dmitry Baryshkov wrote: > On 27/07/2023 23:14, Marijn Suijten wrote: > > On 2023-07-27 19:21:02, Dmitry Baryshkov wrote: > >> Replace the only user of the DPU_INTF_TE feature flag with the direct > >> DPU version comparison. > >> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > > >> --- > >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ++-- > >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 - > >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 -- > >> 3 files changed, 2 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > >> index 9589fe719452..60d4dd88725e 100644 > >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > >> @@ -776,8 +776,8 @@ struct dpu_encoder_phys *dpu_encoder_phys_cmd_init( > >> phys_enc->intf_mode = INTF_MODE_CMD; > >> cmd_enc->stream_sel = 0; > >> > >> - phys_enc->has_intf_te = test_bit(DPU_INTF_TE, > >> - &phys_enc->hw_intf->cap->features); > >> + if (phys_enc->dpu_kms->catalog->mdss_ver->core_major_ver >= 5) > >> + phys_enc->has_intf_te = true; > > > > We could also check if the INTF block has the callbacks (which it based > > on the presence of the interrupt line in the catalog instead), but then > > I think we might loose some extra validation which you tidied up in a > > later patch in this series? > > Almost. The logic was the following: we should be using INTF for DPU >= > 5.0. And if we have DPU >= 5.0 and no callbacks, it's an error. Indeed. Let's keep that validation just in case. - Marijn
