On 2023-07-27 19:21:03, Dmitry Baryshkov wrote: > The dpu_encoder_phys_cmd_te_rd_ptr_irq() function uses neither hw_intf > nor hw_pp data, so we can drop the corresponding check. Maybe because it would catch "bogus" interrupts, or these blocks are accessed somewhere down the line in the vblank callback chain? I have no clue :) > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > index 60d4dd88725e..04a1106101a7 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > @@ -108,14 +108,6 @@ static void dpu_encoder_phys_cmd_te_rd_ptr_irq(void *arg) > struct dpu_encoder_phys *phys_enc = arg; > struct dpu_encoder_phys_cmd *cmd_enc; > > - if (phys_enc->has_intf_te) { > - if (!phys_enc->hw_intf) > - return; > - } else { > - if (!phys_enc->hw_pp) > - return; > - } > - > DPU_ATRACE_BEGIN("rd_ptr_irq"); > cmd_enc = to_dpu_encoder_phys_cmd(phys_enc); > > -- > 2.39.2 >