Javier Martinez Canillas <javierm@xxxxxxxxxx> writes: > Drivers are not allowed to fail after drm_atomic_helper_swap_state() has > been called and the new atomic state is stored into the current sw state. > > Since the struct ssd130x_device .data_array is allocated in the encoder's > .atomic_enable callback, the operation can fail and this is after the new > state has been stored. So it can break an atomic mode settings assumption. > > Fix this by having custom helpers to allocate, duplicate and destroy the > plane state, that will take care of allocating and freeing these buffers. > > Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx> > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > Acked-by: Maxime Ripard <mripard@xxxxxxxxxx> > Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
