Geert Uytterhoeven <geert+renesas@xxxxxxxxx> writes:
Hello Geert,
Thanks a lot for your patch!
> If CONFIG_FB_CORE=y but CONFIG_FB=n, the frame buffer bootup logos can
> no longer be enabled. Fix this by making CONFIG_LOGO depend on
> CONFIG_FB_CORE instead of CONFIG_FB, as there is no good reason for the
> logo code to depend on the presence of real frame buffer device drivers.
>
Indeed.
> Fixes: 55bffc8170bb5813 ("fbdev: Split frame buffer support in FB and FB_CORE symbols")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> drivers/video/Kconfig | 2 +-
> drivers/video/logo/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index e5b1cc54cafa10d5..b694d7669d3200b1 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -63,7 +63,7 @@ if VT
> source "drivers/video/console/Kconfig"
> endif
>
> -if FB || SGI_NEWPORT_CONSOLE
> +if FB_CORE || SGI_NEWPORT_CONSOLE
> source "drivers/video/logo/Kconfig"
>
> endif
> diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig
> index 6d6f8c08792dc897..b7d94d1dd1585a84 100644
> --- a/drivers/video/logo/Kconfig
> +++ b/drivers/video/logo/Kconfig
> @@ -5,7 +5,7 @@
>
> menuconfig LOGO
> bool "Bootup logo"
> - depends on FB || SGI_NEWPORT_CONSOLE
> + depends on FB_CORE || SGI_NEWPORT_CONSOLE
> help
> Enable and select frame buffer bootup logos.
Should then move this option to drivers/video/fbdev/core/Kconfig ?
Regardless, could be done as a follow-up and the fix looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
