On Tue, 25 Jul 2023 09:47:02 +0200 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote: > On Sun, 23 Jul 2023 02:47:44 +0300 > Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> wrote: > > > Add locked/unlocked postfixes to drm-shmem function names to make clear > > where reservation lock is taken and where not. > > Uh, ignore my comment on patch 1 then... > > > Add more common helpers to drm_gem_shmem_helper.h > > I'd do the renaming and exporting in separate patches. Actually, I'd refrain from exporting functions until someone needs them, as you rightfully pointed out in your previous reply. > > > > > Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>