On Tue, Jul 25, 2023 at 1:59 AM Justin Green <greenjustin@xxxxxxxxxxxx> wrote: > > Add a check to mtk_drm_mode_fb_create() that rejects any modifier that > is not the AFBC mode supported by MT8195's display overlays. > > Tested by booting ChromeOS and verifying the UI works, and by running > the ChromeOS kms_addfb_basic binary, which has a test called > "addfb25-bad-modifier" that attempts to create a framebuffer with the > modifier DRM_FORMAT_MOD_INVALID and verifies the ADDFB2 ioctl returns > EINVAL. > > Signed-off-by: Justin Green <greenjustin@xxxxxxxxxxxx> Tested-by: Fei Shao <fshao@xxxxxxxxxxxx> Tested the UI and with the aforementioned binary on a MT8195 Chromebook (AFBC supported) and a MT8188 Chromebook (AFBC not supported at this moment).
