> -----Original Message----- > From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Tvrtko > Ursulin > Sent: Friday, July 21, 2023 6:08 AM > To: Intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > Cc: Ursulin, Tvrtko <tvrtko.ursulin@xxxxxxxxx> > Subject: [PATCH] drm/i915: Use the i915_vma_flush_writes helper > > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > We can use the existing helper in flush_write_domain() and save some lines > of code. > LGTM, Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx> --Radhakrishna(RK) Sripada > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > --- > drivers/gpu/drm/i915/gem/i915_gem_domain.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_domain.c > b/drivers/gpu/drm/i915/gem/i915_gem_domain.c > index dfaaa8b66ac3..ffddec1d2a76 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_domain.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_domain.c > @@ -68,10 +68,8 @@ flush_write_domain(struct drm_i915_gem_object *obj, > unsigned int flush_domains) > switch (obj->write_domain) { > case I915_GEM_DOMAIN_GTT: > spin_lock(&obj->vma.lock); > - for_each_ggtt_vma(vma, obj) { > - if (i915_vma_unset_ggtt_write(vma)) > - intel_gt_flush_ggtt_writes(vma->vm->gt); > - } > + for_each_ggtt_vma(vma, obj) > + i915_vma_flush_writes(vma); > spin_unlock(&obj->vma.lock); > > i915_gem_object_flush_frontbuffer(obj, ORIGIN_CPU); > -- > 2.39.2