On Fri, Jul 21, 2023 at 11:58 AM Ying Liu <victor.liu@xxxxxxx> wrote:
>
> If gpio pin is in input state but backlight is currently off due to
GPIO
> default pull downs, then initial power state is set to FB_BLANK_UNBLANK
> in DT boot mode with phandle link and the backlight is effectively
> turned on in gpio_backlight_probe(), which is undesirable according to
> patch description of commit ec665b756e6f ("backlight: gpio-backlight:
> Correct initial power state handling").
>
> Quote:
> ---
> If in DT boot we have phandle link then leave the GPIO in a state which the
> bootloader left it and let the user of the backlight to configure it further.
> ---
Just use ---8<--- or drop these completely, as your (commit message of
the) patch is broken now.
>
> So, let's drop output gpio direction check and only check gpio value to set
GPIO
GPIO
> the initial power state.
>
> Fixes: 706dc68102bc ("backlight: gpio: Explicitly set the direction of the GPIO")
> Signed-off-by: Liu Ying <victor.liu@xxxxxxx>
--
With Best Regards,
Andy Shevchenko
