Re: [PATCH v6 02/11] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Reviewed-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>

On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote:
Everytime we run bridge detection and/or EDID read we run a poweron
and poweroff sequence for both the AUX and the panel; moreover, this
is also done when enabling the bridge in the .atomic_enable() callback.

Move this power on/off sequence to a new mtk_dp_aux_panel_poweron()
function as to commonize it.
Note that, before this commit, in mtk_dp_bridge_atomic_enable() only
the AUX was getting powered on but the panel was left powered off if
the DP cable wasn't plugged in while now we unconditionally send a D0
request and this is done for two reasons:
  - First, whether this request fails or not, it takes the same time
    and anyway the DP hardware won't produce any error (or, if it
    does, it's ignorable because it won't block further commands)
  - Second, training the link between a sleeping/standby/unpowered
    display makes little sense.

--
Regards,
Alexandre



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux